chore: bump meteor 3.3.2 by ggazzo · Pull Request #37336 · RocketChat/Rocket.Chat

ggazzo · 2025-10-29T16:49:47Z

https://rocketchat.atlassian.net/browse/ARCH-1847

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Chores
- Upgraded Meteor framework to 3.3.2.
- Applied patch updates to core packages (accounts, compilation, ECMAScript, TypeScript, Mongo/minimongo, shell-server) for stability and compatibility.
- Bumped MongoDB driver across apps and packages to 6.16.0 to align runtime dependencies.

dionisio-bot · 2025-10-29T16:49:50Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is targeting the wrong base branch. It should target 7.13.0, but it targets 7.12.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2025-10-29T16:49:51Z

⚠️ No Changeset found

Latest commit: bfa6b37

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-10-29T16:50:37Z

Walkthrough

Bumped Meteor release to METEOR@3.3.2 and upgraded multiple Meteor package patch versions; updated many package.json files across apps, ee packages, and core packages to use mongodb 6.16.0 (from 6.10.0) and other patch bumps in Meteor manifests.

Changes

Cohort / File(s)	Summary
Meteor release & manifests `apps/meteor/.meteor/release`, `apps/meteor/.meteor/packages`, `apps/meteor/.meteor/versions`	Release updated to METEOR@3.3.2; multiple Meteor package patch bumps (accounts-base, accounts-password, mongo, shell-server, babel-compiler, ecmascript, typescript, minimongo, npm-mongo, boilerplate-generator, callback-hook, modern-browsers, etc.). No package additions/removals.
Top-level / app MongoDB driver bumps `apps/meteor/package.json`, `apps/meteor/ee/server/services/package.json`	Updated `mongodb` dependency from 6.10.0 → 6.16.0.
EE apps - MongoDB driver bumps `ee/apps/*/package.json` `ee/apps/account-service/package.json`, `ee/apps/authorization-service/package.json`, `ee/apps/ddp-streamer/package.json`, `ee/apps/omnichannel-transcript/package.json`, `ee/apps/presence-service/package.json`, `ee/apps/queue-worker/package.json`, `ee/apps/stream-hub-service/package.json`	Updated `mongodb` dependency from 6.10.0 → 6.16.0 in multiple EE application package manifests.
EE packages - MongoDB driver bumps `ee/packages/*/package.json` `ee/packages/federation-matrix/package.json`, `ee/packages/omni-core-ee/package.json`, `ee/packages/omnichannel-services/package.json`, `ee/packages/presence/package.json`	Updated `mongodb` dependency from 6.10.0 → 6.16.0.
Core packages & utilities - MongoDB devDependency bumps `packages/*/package.json` `packages/agenda/package.json`, `packages/core-services/package.json`, `packages/core-typings/package.json`, `packages/cron/package.json`, `packages/instance-status/package.json`, `packages/model-typings/package.json`, `packages/mongo-adapter/package.json`, `packages/omni-core/package.json`, `packages/rest-typings/package.json`, `packages/ui-contexts/package.json`	Updated `mongodb` (dependency or devDependency) from 6.10.0 → 6.16.0 across multiple packages. No other changes to code or exports.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Areas to inspect closely:
- apps/meteor/.meteor/versions and apps/meteor/.meteor/packages for large npm-mongo jump (6.10.x → 6.16.x) and related Meteor package interactions.
- Any server-side code relying on MongoDB driver internals or APIs (app and EE services).
- Compatibility of Meteor 3.3.2 with app TypeScript/babel/ecmascript toolchain.

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

rodrigok

Poem

🐇 I hopped by the manifests bright,
Bumped Meteor and drivers overnight.
Packages tuned, versions anew,
A tidy patch-hop — one, two, two!
Cheers from the rabbit — code review delight.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "chore: bump meteor 3.3.2" accurately describes the primary change in the changeset. The raw summary confirms that the Meteor release version is upgraded from METEOR@3.3 to METEOR@3.3.2, and multiple Meteor package versions are bumped accordingly. The title is concise, uses an appropriate commit prefix, and clearly indicates the main objective without unnecessary noise or vague language.
Linked Issues Check	✅ Passed	The linked issue ARCH-1847 is titled "bump meteor 3.3.2" without additional detailed requirements provided. The code changes demonstrate that the primary objective has been met: the Meteor release version was upgraded from METEOR@3.3 to METEOR@3.3.2, and corresponding Meteor package versions (accounts-base, accounts-password, mongo, shell-server, babel-compiler, ecmascript, typescript, and others) were bumped to their compatible versions. The changes align with the stated objective in the linked issue.
Out of Scope Changes Check	✅ Passed	The changeset includes a MongoDB driver version bump (6.10.0 to 6.16.0) across multiple package.json files throughout the repository, in addition to the Meteor version upgrades. This MongoDB update appears to be a transitive dependency update associated with the Meteor 3.3.2 upgrade, as evidenced by the coordinated version changes across the Meteor packages in .meteor/versions and the consistent pattern of MongoDB updates across enterprise and core packages. The changes are cohesive and consistent with a standard dependency upgrade workflow.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch chore/bump-meteor

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 624c67b and bfa6b37.

⛔ Files ignored due to path filters (1)

yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (23)

apps/meteor/ee/server/services/package.json (1 hunks)
apps/meteor/package.json (1 hunks)
ee/apps/account-service/package.json (1 hunks)
ee/apps/authorization-service/package.json (1 hunks)
ee/apps/ddp-streamer/package.json (1 hunks)
ee/apps/omnichannel-transcript/package.json (1 hunks)
ee/apps/presence-service/package.json (1 hunks)
ee/apps/queue-worker/package.json (1 hunks)
ee/apps/stream-hub-service/package.json (1 hunks)
ee/packages/federation-matrix/package.json (1 hunks)
ee/packages/omni-core-ee/package.json (1 hunks)
ee/packages/omnichannel-services/package.json (1 hunks)
ee/packages/presence/package.json (1 hunks)
packages/agenda/package.json (1 hunks)
packages/core-services/package.json (1 hunks)
packages/core-typings/package.json (1 hunks)
packages/cron/package.json (1 hunks)
packages/instance-status/package.json (1 hunks)
packages/model-typings/package.json (1 hunks)
packages/mongo-adapter/package.json (1 hunks)
packages/omni-core/package.json (1 hunks)
packages/rest-typings/package.json (1 hunks)
packages/ui-contexts/package.json (1 hunks)

✅ Files skipped from review due to trivial changes (2)

packages/cron/package.json
ee/apps/account-service/package.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: 📦 Build Packages
GitHub Check: CodeQL-Build
GitHub Check: CodeQL-Build

🔇 Additional comments (23)

packages/instance-status/package.json (1)

9-9: No breaking changes between mongodb 6.10.0 and 6.16.0—upgrade is safe.

The changes between these versions are feature additions, deprecations, and bug fixes, not breaking API changes. 6.16.0 includes the Collection.distinct() hint parameter and server 4.0 deprecation, plus several bug fixes. This patch-level upgrade is compatible and safe to proceed with.

packages/model-typings/package.json (1)

8-8: MongoDB 6.16.0 is compatible with Meteor 3.3.2—no action required.

Verification confirms that Meteor 3.3.2 uses MongoDB driver 6.16.x as the default driver, making this exact version pinning appropriate and correct. No breaking changes exist between 6.10.0 and 6.16.0. The upgrade is justified as part of the Meteor 3.3.2 bump.

ee/apps/stream-hub-service/package.json (1)

33-33: LGTM!

The MongoDB driver update to 6.16.0 is a straightforward patch version bump and aligns with the coordinated upgrade across the monorepo.

ee/packages/federation-matrix/package.json (1)

49-49: LGTM!

Standard MongoDB driver patch version update aligns with the coordinated upgrade across the monorepo.

ee/apps/omnichannel-transcript/package.json (1)

42-42: LGTM!

Standard MongoDB driver patch version update aligned with the coordinated monorepo upgrade.

packages/omni-core/package.json (1)

34-34: LGTM!

Standard MongoDB driver patch version update aligned with the coordinated monorepo upgrade.

ee/apps/authorization-service/package.json (1)

34-34: LGTM!

Standard MongoDB driver patch version update aligned with the coordinated monorepo upgrade.

ee/apps/ddp-streamer/package.json (1)

36-36: LGTM!

Standard MongoDB driver patch version update aligned with the coordinated monorepo upgrade.

packages/core-services/package.json (1)

17-17: LGTM!

Standard MongoDB driver patch version update aligned with the coordinated monorepo upgrade.

ee/packages/presence/package.json (1)

38-38: Consistent MongoDB driver bump across presence package.

Aligns with coordinated upgrade strategy; approval contingent on verification of driver compatibility.

ee/packages/omni-core-ee/package.json (1)

33-33: Consistent MongoDB driver update across omni-core-ee.

Part of coordinated codebase-wide upgrade.

packages/agenda/package.json (1)

12-12: Consistent MongoDB driver update across agenda package.

Part of coordinated codebase-wide upgrade.

packages/core-typings/package.json (1)

11-11: MongoDB driver devDependency update (lower production risk).

Consistent with codebase-wide upgrade; used for type definitions and development-time checks.

packages/ui-contexts/package.json (1)

22-22: MongoDB driver devDependency update (lower production risk).

Consistent with codebase-wide upgrade.

ee/packages/omnichannel-services/package.json (1)

36-36: Consistent MongoDB driver update across omnichannel-services.

Part of coordinated codebase-wide upgrade.

ee/apps/presence-service/package.json (1)

34-34: Consistent MongoDB driver update across presence-service.

Part of coordinated codebase-wide upgrade.

apps/meteor/package.json (1)

405-405: MongoDB driver 6.16.0 upgrade is safe and backward compatible.

The update contains no breaking changes between 6.10.0 and 6.16.0. Changes include a new optional distinct hint parameter, bug fixes for network message processing and FindCursor.rewind(), and deprecation (not removal) of MongoDB Server 4.0 support. This is a non-breaking improvement release suitable for production.

ee/apps/queue-worker/package.json (2)

36-36: Verify MongoDB 6.16.0 compatibility with Meteor 3.3.2.

The mongodb 6.16.0 release includes a new Collection.distinct() hint parameter (requires MongoDB Server 7.1+) and fixes for message processing and cursor rewind bugs. This is a safe minor version bump with no breaking changes from 6.10.0 in this version range. However, verify that Meteor 3.3.2 is compatible and that no Meteor-specific mongodb usage patterns are affected.

36-36: MongoDB 6.16.0 is safe and verified compatible with Meteor 3.3.2.

Meteor 3.3.x (including 3.3.2) uses the MongoDB Node.js driver 6.16.x by default and is compatible with that driver for MongoDB servers >=4.0. This is not just a supported version—it's the official default driver for Meteor 3.3.2, so the bump from 6.10.0 to 6.16.0 aligns with the framework's own release. Ensure your Meteor runtime meets the Node.js requirement: mongodb v6.x requires Node.js >= 16.20.1.

packages/rest-typings/package.json (2)

10-10: MongoDB 6.16.0 update as devDependency is low-risk.

Since mongodb is a devDependency (used only for type generation/verification), the impact is limited to build time. The bump from 6.10.0 to 6.16.0 is safe. However, still verify compatibility with Meteor 3.3.2 if this package's types are used in runtime contexts.

10-10: MongoDB 6.16.0 update as devDependency is low-risk.

Since mongodb is a devDependency (used only for type generation/verification), the bump to 6.16.0 has minimal runtime impact. The change aligns with the repository-wide update and introduces no breaking changes.

apps/meteor/ee/server/services/package.json (2)

42-42: MongoDB 6.16.0 update looks good; verify EE service integration testing.

The mongodb driver bump is consistent across the codebase. However, since this is a critical EE service, confirm that integration tests were run to validate the new driver version works correctly with the service's database operations.

42-42: MongoDB 6.16.0 update looks good; verify EE service integration testing.

The mongodb driver bump is consistent across the codebase. Since this is a critical EE service dependency with database operations, confirm that integration tests validated the new driver version works correctly with the service layer and core models package interactions.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2025-10-29T17:46:49Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.93%. Comparing base (1acf6a3) to head (bfa6b37).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #37336   +/-   ##
========================================
  Coverage    67.92%   67.93%           
========================================
  Files         3356     3356           
  Lines       114886   114887    +1     
  Branches     20755    20757    +2     
========================================
+ Hits         78042    78044    +2     
+ Misses       34159    34152    -7     
- Partials      2685     2691    +6

Flag	Coverage Δ
e2e	`57.42% <ø> (-0.05%)`	⬇️
e2e-api	`40.58% <ø> (+0.07%)`	⬆️
unit	`72.00% <ø> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…and yarn.lock files

bump meteor 3.3.2

624c67b

ggazzo added this to the 7.13.0 milestone Oct 30, 2025

ggazzo marked this pull request as ready for review October 30, 2025 14:46

chore: update mongodb version to 6.16.0 across multiple package.json …

bfa6b37

…and yarn.lock files

ggazzo requested review from a team as code owners October 30, 2025 14:52

KevLehman approved these changes Oct 30, 2025

View reviewed changes

sampaiodiego approved these changes Oct 30, 2025

View reviewed changes

ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 30, 2025

tassoevan approved these changes Oct 30, 2025

View reviewed changes

ggazzo merged commit 5c57e84 into develop Oct 30, 2025
50 checks passed

ggazzo deleted the chore/bump-meteor branch October 30, 2025 15:57

rodrigok pushed a commit that referenced this pull request Oct 30, 2025

chore: bump meteor 3.3.2 (#37336)

bf0284e

This was referenced Nov 12, 2025

chore: upgrade mongodb to 7.0.0 to fix AWS IAM credentials #37490

Closed

chore(ci): do not include dev dependencies in docker images #37481

Merged

coderabbitai bot mentioned this pull request Dec 17, 2025

Upgrading from 7.11.2 to 7.13.1 Application Crash #37863

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump meteor 3.3.2#37336

chore: bump meteor 3.3.2#37336
ggazzo merged 2 commits intodevelopfrom
chore/bump-meteor

ggazzo commented Oct 29, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

dionisio-bot bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

codecov bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ggazzo commented Oct 29, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Uh oh!

dionisio-bot bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested labels

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

codecov bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ggazzo commented Oct 29, 2025 •

edited by coderabbitai bot

Loading

dionisio-bot bot commented Oct 29, 2025 •

edited

Loading

changeset-bot bot commented Oct 29, 2025 •

edited

Loading

coderabbitai bot commented Oct 29, 2025 •

edited

Loading

codecov bot commented Oct 29, 2025 •

edited

Loading